Re: [libvirt] [PATCH 31/34] qemu: Replace checking for vcpu<->pid mapping availability with a helper

On 11/20/2015 10:22 AM, Peter Krempa wrote: > Add qemuDomainHasVCpuPids to do the checking and replace in place checks > with it. > --- > src/qemu/qemu_cgroup.c | 7 ++----- > src/qemu/qemu_domain.c | 15 +++++++++++++++ > src/qemu/qemu_domain.h | 2 ++ > src/qemu/qemu_driver.c | 29 +++++++++++++---------------- > src/qemu/qemu_process.c | 7 ++++--- > 5 files changed, 36 insertions(+), 24 deletions(-) > Well I got close - reached critical mass here. > diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c > index 3c7694a..56c2e90 100644 > --- a/src/qemu/qemu_cgroup.c > +++ b/src/qemu/qemu_cgroup.c > @@ -1005,12 +1005,9 @@ qemuSetupCgroupForVcpu(virDomainObjPtr vm) > !virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_CPUSET)) > return 0; > > - if (priv->nvcpupids == 0 || priv->vcpupids[0] == vm->pid) { > - /* If we don't know VCPU<->PID mapping or all vcpu runs in the same > - * thread, we cannot control each vcpu. > - */ I'm curious about the vcpupids[0] == vm->pid checks... I feel like I missed some nuance with the last patch. Perhaps a bit more explanation with regard to what happened will help. What up to this point so far including this patch allows the "safe" removal of that check