Re: [libvirt] [PATCH] Rework configure logic for virtualport support
On 09/28/2010 01:52 PM, Eric Blake wrote:
On 09/28/2010 11:01 AM, Stefan Berger wrote:
>
> -AC_TRY_COMPILE([ #include <sys/socket.h>
> - #include <linux/rtnetlink.h> ],
> - [ int x = IFLA_PORT_MAX; ],
> - [ with_virtualport=yes ],
> - [ with_virtualport=no ])
> -if test "$with_virtualport" = "yes"; then
> - val=1
> -else
> - val=0
> +val=0
> +if test "$with_virtualport" != "no"; then
Hmm - here you use $with_virtualport without adding an
AC_ARG_WITH([virtualport]), which means the user doesn't have an easy
way to set this variable via ./configure --with-virtualport.
I think we need a v2 that adds the AC_ARG_WITH.
Ooops.
>
> -if test "$with_macvtap" = "yes" || test
"$with_virtualport" = "yes";
> then
> +if test "$with_macvtap" = "yes"; then
> PKG_CHECK_MODULES([LIBNL], [libnl-1 >= $LIBNL_REQUIRED], [
So virtualport doesn't require libnl. The rest of your logic looks
okay, once we get the AC_ARG_WITH sorted out.
virtualport support requires macvtap -- at least at the moment -- which
in turn requires libnl.
[virtualport support could be used with directly mapped PCI devices (not
needing macvtap), but there is no support for this atm. In that case the
two will become independent of each other.]
Will send a V2 shortly.
Stefan