Re: [PATCH] qemu: capabilities: Remove check for /usr/libexec/qemu-kvm
On Fri, Apr 01, 2022 at 03:52:34PM -0600, Jim Fehlig wrote:
On 3/30/22 10:59, Andrea Bolognani wrote:
> I agree that the message being logged is not very useful, but I don't
> think the approach you take here is the correct one: we want upstream
> libvirt to work out of the box when built on a variety of distros,
> including RHEL and derivatives, and your patch breaks that.
Do the minimum RHEL and derivatives supported upstream still provide
/usr/libexec/qemu-kvm?
Yup. And the path that other distros as well as upstream QEMU use
doesn't exist, so we are forced to have this special handling.
$ podman run --rm quay.io/centos/centos:stream8 \
sh -c 'yum install -y qemu-kvm-core && rpm -ql qemu-kvm-core'
2>&1 \
| grep -E '/usr/libexec/qemu-kvm|/usr/bin/qemu-system-x86_64'
/usr/libexec/qemu-kvm
$ podman run --rm quay.io/centos/centos:stream9 \
sh -c 'yum install -y qemu-kvm-core && rpm -ql qemu-kvm-core'
2>&1 \
| grep -E '/usr/libexec/qemu-kvm|/usr/bin/qemu-system-x86_64'
/usr/libexec/qemu-kvm
Luckily, now that thanks to your report I've cleaned things up it's
not actually that bad :)
--
Andrea Bolognani / Red Hat / Virtualization