Re: [libvirt] [PATCH 6/6] qemu: monitor: Properly configure backend for UDP chardevs
On 09/27/2016 12:39 PM, Peter Krempa wrote:
Since introduction of chardev hotplug the code was wrong for the UDP
case and basically created a TCP socket instead. Use proper objects and
type for UDP.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1377602
---
src/qemu/qemu_monitor_json.c | 12 ++++++++++--
tests/qemumonitorjsontest.c | 20 ++++++++++++++++----
2 files changed, 26 insertions(+), 6 deletions(-)
As I read the bug, the code below, and the qemu_command code - it seems
the bug describes issues with both qemu_command and the hotplug code.
Although for sure the hotplug code is wrong - there's no adjustment in
the qemu_command code, so it doesn't seem this patch addresses all the
concerns in the bz.
ACK to the change, but I'm not sure you can claim victory over the bz if
the qemu_command logic is still flawed...
John