[libvirt] [PATCH v2 1/7] hellolibvirt: Resolve Coverity issues
Recent changes uncovered a NEGATIVE_RETURNS when processing 'numNames'
in 'showDomains' in the for loop after a possible -1 return.
---
examples/hellolibvirt/hellolibvirt.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/examples/hellolibvirt/hellolibvirt.c b/examples/hellolibvirt/hellolibvirt.c
index 83045b1..0179fad 100644
--- a/examples/hellolibvirt/hellolibvirt.c
+++ b/examples/hellolibvirt/hellolibvirt.c
@@ -90,6 +90,13 @@ showDomains(virConnectPtr conn)
numNames = virConnectListAllDomains(conn,
&nameList,
flags);
+ if (numNames == -1) {
+ ret = 1;
+ printf("Failed to get a list of all domains: %s\n",
+ virGetLastErrorMessage());
+ goto out;
+ }
+
for (i = 0; i < numNames; i++) {
int active = virDomainIsActive(nameList[i]);
printf(" %8s (%s)\n",
--
1.8.1.4