Re: [libvirt] [Xen-devel] [PATCH] libxl: initialize vfb defbools in libxlMakeVfb

Ian Campbell wrote: > On Fri, 2015-04-17 at 13:57 -0600, Jim Fehlig wrote: > >> On 04/17/2015 11:59 AM, Olaf Hering wrote: >> >>> On Fri, Apr 17, Olaf Hering wrote: >>> >>> >>>> If the domU configu has sdl enabled libvirtd crashes: >>>> libvirtd[5158]: libvirtd: libxl.c:343: libxl_defbool_val: Assertion `!libxl_defbool_is_default(db)' failed. >>>> >>>> Initialize the relevant defbool variables in libxl_device_vfb. >>>> >>> Fix one crash, find another: >>> >>> Does libvirt have a representation for this one? >>> >>> libxl_defbool_val(vfb.sdl.opengl)); >>> >> I'm not aware of any way to specify OpenGL in libvirt domXML. >> >> >>> If not, it should be initialized to false in libxlMakeVfb. >>> >> As before, seems like the init function should handle this. >> > > As before, _not_ the init function, the setdefault within libxl should > ensure that this is set to some value _before_ it is used. These changes > are just hiding libxl bugs. > Yes, I agree. > Olaf, please can you use gdb to capture the stack trace so we can fix > this (and the other issue) properly in libxl instead of just hacking > around it in libvirt (which might also be appropriate for compat with > old libxl but shouldn't be done without also fixing libxl IMHO). > I was torn on committing Olaf's changes to the libvirt libxl driver, but in the end did so for the compatibility you noted.