Re: [libvirt] [PATCHv3 2/5] snapshot: qemu: Fix detection of external snapshots when deleting

On 11/12/2012 10:49 AM, Peter Krempa wrote: > This patch adds a helper to determine if snapshots are external and uses > the helper to fix detection of those in snapshot deletion code. > > Snapshots are external if they have an external memory image or if the > disk locations are external. As mixed snapshots are forbidden for now > we need to check just one disk to know. > --- > - Squashed the patch adding the helper with the actual fix. > - Fixed detection of external snapshots > --- > src/conf/snapshot_conf.c | 17 +++++++++++++++++ > src/conf/snapshot_conf.h | 2 ++ > src/libvirt_private.syms | 1 + > src/qemu/qemu_driver.c | 6 +++--- > 4 files changed, 23 insertions(+), 3 deletions(-) ACK; this can be applied now, in part because I need this particular patch for my next post. I still need to look at the rest of your series, though.