Re: [libvirt] [PATCH] daemon: Fix compilation error of dispatch.c

On Thu, Jul 08, 2010 at 03:53:06AM +0900, Ryota Ozaki wrote: > On Thu, Jul 8, 2010 at 3:31 AM, Ryota Ozaki <ozaki.ryota(a)gmail.com&gt; wrote: > > On Thu, Jul 8, 2010 at 2:40 AM, Daniel Veillard <veillard(a)redhat.com&gt; wrote: > >> On Thu, Jul 08, 2010 at 01:55:23AM +0900, Ryota Ozaki wrote: > >>> > Unfortunately the errors still happen after updating. Even worse, they happen > >>> > on an old commit that I was able to compile successfully so far. So I guess > >>> > my box went wrong at some point. > >>> > >>> FYI. My box has repaired by removing /usr/local/include/rpc/ which is > >>> installed by > >>> portablexdr to build MinGW cross-compile environment. I don´t know why/how the > >>> headers affect to libvirt compilation. > >> > >>  Huh, that's weird, maybe the compiler takes /usr/local/include/blah... > >> before /usr/include/blah... > > > > My box's gcc seems trying to search /usr/local/include firstly... > > I'm not sure this is expected behavior or not. > > Anyway, dispatch.c requires stdio.h but now it implicitly depends on that > rpc/xdr.h includes stdio.h. > > [Inclusions] > dispatch.c >   libvirtd.h >     rpc/xdr.h >       stdio.h > > I think including stdio.h explicitly in dispatch.c is not bad idea. > How do you think, Daniel? Yes, we shouldn't rely on rpc/xdr.h to include it

Daniel -- |: Red Hat, Engineering, London    -o-   http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org        -o-         http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505  -o-   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|