Re: [libvirt] [PATCH] tests: qemu: mock master key generation

On 05/11/2016 07:36 AM, Peter Krempa wrote: > The master key generation is using host state to get the random bytes. > Currently it's not used so it doesn't break any tests, but it may become > a problem in the future. > > Fix it by mocking qemuDomainGenerateRandomKey. This is possible after > exporting it and switching to the dynamically linked qemu driver object > for tests. > --- > This also makes the test not call any gnutls function which crashed certain > gnutls versions as we did not initialize it (gnutls_global_init()). It may be > also worth adding the call to virtTestMain so that tests don't run into that > problem, but I'm not totaly persuaded that it's a good idea. > > src/qemu/qemu_domain.c | 2 +- > src/qemu/qemu_domain.h | 2 ++ > tests/Makefile.am | 2 +- > tests/qemuxml2argvmock.c | 21 +++++++++++++++++++++ > 4 files changed, 25 insertions(+), 2 deletions(-) > I think I addressed this in patch 2 of my series: http://www.redhat.com/archives/libvir-list/2016-May/msg00444.html