Re: [libvirt] [PATCH v2 22/33] qemu: Get host CPU model from QEMU on x86_64
On Tue, Feb 21, 2017 at 22:28:25 -0500, John Ferlan wrote:
...
> diff --git a/src/qemu/qemu_capabilities.c
b/src/qemu/qemu_capabilities.c
> index f115f1e23..bcfb6b694 100644
> --- a/src/qemu/qemu_capabilities.c
> +++ b/src/qemu/qemu_capabilities.c
> @@ -3128,6 +3128,77 @@ virQEMUCapsInitCPUModelS390(virQEMUCapsPtr qemuCaps,
> * -1 on error.
> */
> static int
> +virQEMUCapsInitCPUModelX86(virQEMUCapsPtr qemuCaps,
> + virDomainVirtType type,
> + virCPUDefPtr cpu)
> +{
> + qemuMonitorCPUModelInfoPtr model;
> + virCPUDataPtr data = NULL;
> + unsigned long long sigFamily = 0;
> + unsigned long long sigModel = 0;
> + size_t nmodels = 0;
> + char **models = NULL;
> + int ret = -1;
> + size_t i;
> +
> + if (type == VIR_DOMAIN_VIRT_KVM)
> + model = qemuCaps->kvmCPUModelInfo;
> + else
> + model = qemuCaps->tcgCPUModelInfo;
Use virQEMUCapsGetHostModel (there's probably a couple of these)...
No. Don't confuse {kvm,tcg}CPUModelInfo with {kvm,tcg}CPUModel.
Jirka