Re: [libvirt] [PATCH 0/4] test_driver: implement virDomainSaveImageGetXMLDesc and virDomainSaveImageDefineXML

On Wed, May 29, 2019 at 02:22:55PM +0200, Ilias Stamatis wrote: > While implementing virDomainSaveImageGetXMLDesc and > virDomainSaveImageDefineXML for the test driver, I realized that there > exists already code for saving and loading test images which can be > reused. However, it needed to be extracted from testDomainSaveFlags and > testDomainRestoreFlags into separate functions. The new functions are > inspired by the corresponding QEMU driver code where e.g. > qemuDomainSaveImageOpen serves as a helper used by other functions. > > This series of patches initially extracts the code mentioned above into > separate functions and then provides the test driver with > implementations for virDomainSaveImageGetXMLDesc and > virDomainSaveImageDefineXML which make use of the newly introduced > functions. > > Ilias Stamatis (4): > test_driver: extract image saving code into a separate function > test_driver: extract image loading code into a separate function > test_driver: implement virDomainSaveImageDefineXML > test_driver: implement virDomainSaveImageGetXMLDesc IMHO each public API should be introduced in a separate series.