Re: [libvirt] [PATCH v2 2/2] security: aa-helper: generate more rules for gl devices

On Mon, 18 Feb 2019, Christian Ehrhardt wrote: I'm sorry I think I wasn't clear on how to add in the .so files. I suggest: virBufferAddLit(&buf, " \"/usr/lib{,32,64}/dri/*.so*\" mr,\n"); virBufferAddLit(&buf, " \"/usr/lib/(a){multiarch}/dri/*.so*\" mr,\n"); virBufferAddLit(&buf, " \"/usr/lib/fglrx/dri/*.so*\" mr,\n"); This is slightly futureproofed with the trailing '*'. On my system, the '**' wasn't needed, but if you observe systems where it is, feel free to keep it. The other parts of this patch looked fine. -- Jamie Strandboge | http://www.canonical.com