Re: [libvirt] [PATCH] Mark all error messages for translation

> diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c > index eb1c9d9..2352637 100644 > --- a/src/conf/storage_conf.c > +++ b/src/conf/storage_conf.c > @@ -1464,7 +1464,7 @@ virStoragePoolObjLoad(virStoragePoolObjListPtr pools, > > if (!virFileMatchesNameSuffix(file, def->name, ".xml")) { > virStorageReportError(VIR_ERR_INVALID_STORAGE_POOL, > - "Storage pool config filename '%s' does not match pool name '%s'", > + _("Storage pool config filename '%s' does not match pool name '%s'"), > path, def->name); > virStoragePoolDefFree(def); > return NULL;

Yup raised by "make syntax-check", ACK,

BTW the rule is that if something breaks "make", "make check" or "make syntax-check", it's fine to commit the fix first (assuming it's not controversial i.e. something patchform specific)