Re: [libvirt] [PATCH] Improve invalid argument checks for the public API

On Tue, May 17, 2011 at 02:45:44PM +0200, Matthias Bolte wrote: > --- > src/libvirt.c | 100 +++++++++++++++++++++++++++++++++++++++++++++++++++++--- > 1 files changed, 94 insertions(+), 6 deletions(-) > @@ -5040,6 +5045,12 @@ virDomainGetSchedulerParameters(virDomainPtr domain, > virDispatchError(NULL); > return -1; > } > + > + if (params == NULL || nparams == NULL) { > + virLibDomainError(VIR_ERR_INVALID_ARG, __FUNCTION__); > + goto error; > + } I was just wondering here if params being NULL couldn't be used to find out the correct value for nparams, but looking at least at the qemu driver code we really expect the array there.

> conn = domain->conn; > > if (conn->driver->domainGetSchedulerParameters) { > @@ -5084,6 +5095,12 @@ virDomainSetSchedulerParameters(virDomainPtr domain, > virDispatchError(NULL); > return -1; > } > + > + if (params == NULL) { > + virLibDomainError(VIR_ERR_INVALID_ARG, __FUNCTION__); > + goto error; > + }