Re: [libvirt] [PATCH v2 10/11] secret: Alter FindByUUID to expect the formatted uuidstr
On Tue, Apr 25, 2017 at 05:15:34PM -0400, John Ferlan wrote:
Since we're storing a virUUIDFormat'd string in our Hash
Table, let's
modify the Lookup API to receive a formatted string as well.
Signed-off-by: John Ferlan <jferlan(a)redhat.com>
---
src/conf/virsecretobj.c | 18 +++++++-----------
src/conf/virsecretobj.h | 2 +-
src/secret/secret_driver.c | 10 +++++-----
3 files changed, 13 insertions(+), 17 deletions(-)
I still don't like this patch and I see why you want to keep converting
UUID to string, it is necessary for the future patches because the *primary*
and *secondary* keys assumes that they will be strings.
I still think that if we will cleanup the UUID lookup somehow, we should stop
converting it to a string and make proper "key*" callbacks that will be used
by our hash table. I'll send a patches to do that.
Let's drop this patch for now to not hold the whole series and move it to
a discussion about the new virObjectPoolableHashTable and
virObjectPoolableHashElement classes.
Pavel
Attachments:
- signature.asc (application/pgp-signature — 833 bytes)