Re: [libvirt] [PATCH 11/11] Revert "Do not allow changing the UUID of a nwfilter"

This reverts commit 46a811db0731cedaea0153fc223faa6096cee5b5. It causes random problems in OpenStack, which displays the following error: """ error : virNWFilterObjAssignDef:3075 : operation failed: filter 'nova-no-nd-reflection' already exists with uuid ef783c9f-ae1c-4242-8cd5-9cef5ec4fa7a """ Special thanks to Vojtech Cima for investigating. Signed-off-by: Cristian Klein <cristiklein(a)gmail.com&gt; --- src/conf/nwfilter_conf.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 074d745..7abeff8 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_conf.c @@ -3065,17 +3065,6 @@ virNWFilterObjAssignDef(virNWFilterObjListPtr nwfilters, return NULL; } virNWFilterObjUnlock(nwfilter); - } else { - nwfilter = virNWFilterObjFindByName(nwfilters, def->name); - if (nwfilter) { - char uuidstr[VIR_UUID_STRING_BUFLEN]; - virUUIDFormat(nwfilter->def->uuid, uuidstr); - virReportError(VIR_ERR_OPERATION_FAILED, - _("filter '%s' already exists with uuid %s"), - def->name, uuidstr); - virNWFilterObjUnlock(nwfilter); - return NULL; - } } if (virNWFilterDefLoopDetect(nwfilters, def) < 0) {