Re: [libvirt] [PATCH 5/7] qemu: Always enable GIC on ARM virt machines

On 02/03/2016 03:26 PM, Andrea Bolognani wrote: > GIC is always available to ARM virt machines, and the domain XML should > reflect this fact. > --- >  src/qemu/qemu_domain.c                                     | 14 ++++++++++++++ >  .../qemuxml2argv-aarch64-aavmf-virtio-mmio.xml             |  1 + >  2 files changed, 15 insertions(+) >  > diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c > index d120e15..5017cbb 100644 > --- a/src/qemu/qemu_domain.c > +++ b/src/qemu/qemu_domain.c > @@ -1241,6 +1241,20 @@ qemuDomainDefAddDefaultDevices(virDomainDefPtr def, >  static int >  qemuDomainDefAddDefaultFeatures(virDomainDefPtr def) >  { > +    switch (def->os.arch) { > +    case VIR_ARCH_ARMV7L: > +    case VIR_ARCH_AARCH64: > +        if (STREQ(def->os.machine, "virt") || > +            STRPREFIX(def->os.machine, "virt-")) { > +            /* GIC is always available to ARM virt machines */ > +            def->features[VIR_DOMAIN_FEATURE_GIC] = VIR_TRISTATE_SWITCH_ON;   See once on - we then have a version='host' and we're good to go.   Of course, as I'm typing I realize that we wouldn't print out version='host' if it were the default...  But that may not be a bad thing - although we could.