Re: [libvirt] [PATCH 2/2] qemu: Use secret objects to pass iSCSI passwords

On Wed, Sep 13, 2017 at 09:05:43 -0400, John Ferlan wrote:

> > I was thinking more about virstoragefile.c and virstoragetest.c. It's > easy enough to fetch the user/password-secret in > virStorageSourceParseBackingJSONiSCSI: > > + const char *user = virJSONValueObjectGetString(json, "user"); > + const char *secret = virJSONValueObjectGetString(json, > "password-secret"); > > But there's not much one can do with it as you get (for example): > > user = "myname" > secret = "virtio-disk1-secret0" > > but an <auth> would look like: > > <auth username='myname'> > <secret type='iscsi' usage='mycluster_myname'/> > </auth> > > So to a degree it's not testable to build the XML as virstoragetest > does. Sine the secret can be built up using the disk alias, it's perhaps > not even worth storing away. Yes, the field is rather useless. I'm even surprised that it's recorded into the backing file string. It may be used as a notification that authentication is required, but without actually adding the secret with correct name, the thing won't work anyways.