Re: [libvirt] [PATCH v2 10/12] qemu: split getting stats for migration and others
On Fri, Feb 17, 2017 at 17:16:54 +0300, Nikolay Shirokovskiy wrote:
On 16.02.2017 18:47, Jiri Denemark wrote:
> On Wed, Dec 28, 2016 at 17:39:19 +0300, Nikolay Shirokovskiy wrote:
>> All domain jobs other than source migration have only one
>> state - active. Only elapsed time is available for such
>> jobs so let's make it more explicit. Also if in future there will
>> be more stats for such jobs we don't want to mess them with
>> migration stats code.
>> ---
>> src/qemu/qemu_driver.c | 58 ++++++++++++++++++++++++++++++++------------------
>> 1 file changed, 37 insertions(+), 21 deletions(-)
>
> NACK, see my reply to 8/12.
>
Can you please clarify? It is not that related to 8 patch as I see it.
It basically just creates separate function for getting migration
stats.
But it also changes when the code to get the stats is run. Previously it
was always run for active migration (and doing so would report an error
on the destination host) while after this patch the code is specifically
run only on the source host. This patch doesn't change anything if 8/12
is unchanged, but the change doesn't make a lot of sense without 8/12.
Also depending on the changes done in 6/12, there may be no need
separate the code at all.
Jirka