Re: [libvirt] [PATCH 3/5] libxl: Move virDomainXMLOptionNew into libxlCreateXMLConf

Daniel P. Berrange wrote: > To allow the test suite to creat the XML option object, > move the virDomainXMLOptionNew call into a libxlCreateXMLConf > method. > > Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; > --- > src/libxl/libxl_conf.c | 7 +++++++ > src/libxl/libxl_conf.h | 2 ++ > src/libxl/libxl_domain.c | 4 ++-- > src/libxl/libxl_driver.c | 4 +--- > 4 files changed, 12 insertions(+), 5 deletions(-) >

> diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c > index e00a3fb..00ff14f 100644 > --- a/src/libxl/libxl_domain.c > +++ b/src/libxl/libxl_domain.c > @@ -1100,6 +1100,8 @@ libxlDomainStart(libxlDriverPrivatePtr driver, virDomainObjPtr vm, > #endif > virHostdevManagerPtr hostdev_mgr = driver->hostdevMgr; > > + libxl_domain_config_init(&d_config); > + > if (libxlDomainObjPrivateInitCtx(vm) < 0) > return ret; > > @@ -1149,8 +1151,6 @@ libxlDomainStart(libxlDriverPrivatePtr driver, virDomainObjPtr vm, > VIR_FREE(managed_save_path); > } > > - libxl_domain_config_init(&d_config); > - > if (libxlBuildDomainConfig(driver->reservedVNCPorts, vm->def, > priv->ctx, &d_config) < 0) > goto endjob; > Are these two hunks fixing a bug you found? :-)