Re: [libvirt] [PATCH RESENT 01/12] libxl: allow script for any network interface, not only bridge

On 04/10/2013 05:10 AM, Daniel P. Berrange wrote: > On Wed, Apr 10, 2013 at 04:44:43AM +0200, Marek Marczykowski wrote: > >> This can be useful for route or NAT networks, or any other custom >> network setup. Especially configuration example in documentation uses >> <script/> tag with type 'ethernet'. >> --- >> src/libxl/libxl_conf.c | 17 +++++------------ >> 1 file changed, 5 insertions(+), 12 deletions(-) >> > The script should not not have been allowed for type='bridge' in > the first place, it is only intended for type='ethernet' usage > and nothing else. > I thought that it was also allowed/necessary for type='bridge' in xen domains. Is this incorrect?

(I agree that it shouldn't be allowed for anything new, though)