Re: [libvirt] [PATCH 1/7] qemu: Save/restore error in error path for qemuDomainSaveInternal

On 01/28/2015 03:25 PM, John Ferlan wrote: > If we get to endjob: because of some error earlier such as perhaps > failure from qemuDomainSaveMemory to open/create the save file and > the attempt to restart the CPU's fails, then we get the error from > that restart attempt displayed to the user rather than the error > from the failed attempt to create a save file. > > Upstream commit id '540c339a' changed the flow of the code moving > the EndAsyncJob call and thus exposing the issue where an error in > restarting CPUs resulted in the following: > > error: Failed to save domain rhel70 to /tmp/pl/rhel70.save > error: internal error: unexpected async job 3 > > where /tmp/pl is a NFS root squashed client where the failure to save > the file (EPERM or ENOTCONN) should result in a failure: > > error: Failed to save domain rhel70 to /tmp/pl/rhel70.save > error: Error from child process creating '/tmp/pl/rhel70.save': Transport endpoint is not connected > > or (REVISIT ORDER - that is if I move the virfile check for ENOTCONN > to sooner, then we'll never see ENOTCONN) Is this a note about the possibility of applying the series in a different order?

> > error: Failed to save domain rhel70 to /tmp/pl/rhel70.save > error: Error from child process creating '/tmp/pl/rhel70.save': Operation not permitted > Signed-off-by: John Ferlan <jferlan(a)redhat.com&gt; > --- > src/qemu/qemu_driver.c | 3 +++ > 1 file changed, 3 insertions(+) > ACK