Re: [libvirt] [PATCH v2 1/3] qemu: Make all SPICE command-line args optional
On Tue, May 17, 2016 at 08:03:11AM -0400, Cole Robinson wrote:
On 05/17/2016 06:11 AM, Christophe Fergeau wrote:
> Hey,
>
> After this patch series, the QEMU command line may not contain port nor
> tls-port if they both were set to '0'. However, QEMU versions older than
> 2.3.0 will error out because they don't have this commit:
> http://git.qemu.org/?p=qemu.git;a=commitdiff;h=cf7856adefebe86e0
>
> I assume we want to keep supporting older QEMU binaries, and that this
> needs to be fixed on libvirt side?
Yes we will want to keep older qemu working. However I think Pavel's patches
address this issue?
Actually as Ján pointed out, older QEMU behaviour before/after these
patches should be unchanged. Only difference is that before QEMU was
always adding port=0/tls-port=0, after the are not present, but QEMU
will default to 0 when they are missing. In both cases (present and set
to 0, and not present and default to 0), we will be getting an error.
I don't think Pavel's patches are going to help there though, but I
don't think that's a problem.
Christophe
Attachments:
- signature.asc (application/pgp-signature — 819 bytes)