Re: [libvirt] [PATCHv2 8/7] snapshot: implement snapshot roots listing in esx

2011/10/3 Eric Blake<eblake(a)redhat.com>: > Commit 9f5e53e introduced the ability to filter snapshots to > just roots, but it was never implemented for ESX until now. > > * src/esx/esx_vi.h (esxVI_GetNumberOfSnapshotTrees) > (esxVI_GetSnapshotTreeNames): Add parameter. > * src/esx/esx_vi.c (esxVI_GetNumberOfSnapshotTrees) > (esxVI_GetSnapshotTreeNames): Allow choice of recursion or not. > * src/esx/esx_driver.c (esxDomainSnapshotNum) > (esxDomainSnapshotListNames): Use it to limit to roots. > --- > src/esx/esx_driver.c | 17 +++++++++++++---- > src/esx/esx_vi.c | 26 ++++++++++++++++---------- > src/esx/esx_vi.h | 6 ++++-- > 3 files changed, 33 insertions(+), 16 deletions(-) Tested, works, ACK. I also tested the case of deleting a root snapshot with multiple children. Works as expected when you delete the root you got multiple new roots.