Re: [libvirt] [PATCH] Fixed build with clang.
On Wed, 2014-02-12 at 06:31 -0700, Eric Blake wrote:
On 02/12/2014 03:36 AM, Cédric Bosdonnat wrote:
> Two unused global variables, and DBUS_TYPE_INVALID used as a const
> char*.
> ---
> src/phyp/phyp_driver.c | 1 -
> src/storage/storage_backend_scsi.c | 24 ------------------------
> src/util/virdbus.c | 2 +-
> 3 files changed, 1 insertion(+), 26 deletions(-)
> +++ b/src/storage/storage_backend_scsi.c
> @@ -107,30 +107,6 @@ struct diskType {
> unsigned long long magic;
> };
>
> -static struct diskType const disk_types[] = {
This is the only use of 'struct diskType'; please also remove that
declaration a couple lines earlier.
Weird that clang didn't report that one after the patch.
--
Cedric