On 01/12/2012 04:03 AM, Jiri Denemark wrote:
This adds support for host-model and host-passthrough CPU modes to qemu driver. The host-passthrough mode is mapped to -cpu host. --- Notes: Version 2: - more verbose commit messages - portability fixes in shell scripts
+++ b/src/qemu/qemu_capabilities.h @@ -113,13 +113,14 @@ enum qemuCapsFlags { QEMU_CAPS_NO_SHUTDOWN = 74, /* usable -no-shutdown */
QEMU_CAPS_DRIVE_CACHE_UNSAFE = 75, /* Is cache=unsafe supported? */ - QEMU_CAPS_PCI_ROMBAR = 76, /* -device rombar=0|1 */ + QEMU_CAPS_PCI_ROMBAR = 76, /* -device rombar=0|1 */ QEMU_CAPS_ICH9_AHCI = 77, /* -device ich9-ahci */ QEMU_CAPS_NO_ACPI = 78, /* -no-acpi */ - QEMU_CAPS_FSDEV_READONLY =79, /* -fsdev readonly supported */ + QEMU_CAPS_FSDEV_READONLY = 79, /* -fsdev readonly supported */
Hmm, this is the second time I've seen a patch that touches some, but not all, of the whitespace inconsistencies earlier in the enum (note that QEMU_CAPS_PCI_ROMBAR uses space while QEMU_CAPS_NO_ACPI uses tab, which means that when you add the prefix of a diff file, the alignment looks screwy). We probably ought to separate whitespace normalization of the enum into a separate patch, and let this one just focus on adding the new value of QEMU_CAPS_CPU_HOST.
- QEMU_CAPS_VIRTIO_BLK_SCSI = 80, /* virtio-blk-pci.scsi */ - QEMU_CAPS_VIRTIO_BLK_SG_IO = 81, /* support for SG_IO commands, reportedly added in 0.11 */ + QEMU_CAPS_VIRTIO_BLK_SCSI = 80, /* virtio-blk-pci.scsi */ + QEMU_CAPS_VIRTIO_BLK_SG_IO = 81, /* support for SG_IO commands, reportedly added in 0.11 */ + QEMU_CAPS_CPU_HOST = 82, /* support for -cpu host */
QEMU_CAPS_LAST, /* this must always be the last item */ };
At any rate, the rest of the patch is sane, and you addressed my comments from v1, so ACK. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org