Re: [libvirt PATCH 1/5] gitlab: use CI for building website contents
On Tue, 2020-03-10 at 10:09 +0000, Daniel P. Berrangé wrote:
+# This artifact published by this job is downloaded by libvirt.org
to
+# be deployed to the web root:
+# https://gitlab.com/libvirt/libvirt/-/jobs/artifacts/master/download?job=w...
+website:
+ script:
+ - mkdir build
+ - cd build
+ - ../autogen.sh $CONFIGURE_OPTS --prefix=$(pwd)/../vroot || (cat config.log
&& exit 1)
+ - make -j $(getconf _NPROCESSORS_ONLN)
+ - make -j $(getconf _NPROCESSORS_ONLN) install
+ - cd ..
+ - mv vroot/share/doc/libvirt/html/ website
+ image: quay.io/libvirt/buildenv-libvirt-fedora-31:latest
+ variables:
+ CONFIGURE_OPTS: --without-libvirtd --without-esx --without-hyperv --without-test
--without-dtrace --without-openvz --without-vmware --without-attr --without-audit
--without-blkid --without-bash-completion --without-capng --without-curl --without-dbus
--without-firewalld --without-fuse --without-glusterfs --without-libiscsi --without-libssh
--without-numactl --without-openwsman --without-pciaccess --without-readline
--without-sanlock --without-sasl --without-selinux --without-ssh2 --without-udev
+ artifacts:
+ expose_as: 'Website'
+ name: 'website'
+ when: on_success
+ expire_in: 30 days
+ paths:
+ - website
The overall idea of building the website as a CI job is a reasonable
one, especially because it will allow us to stop periodically
speding time convincing libvirt to build just enough on what has long
been an unsupported target.
A couple of more technical questions:
* why do we care about whether all those features are enabled or
not? It's pretty ugly to have that list hardcoded in our build
scripts, and I don't quite get the point in having it in the
first place;
* as a follow up, why would this be a separate job? We are always
going to build the website on one of our supported targets, so
basically we end up building it twice...
Can't we just generate the artifact as a side-effect of the regular
Fedora 31 build?
--
Andrea Bolognani / Red Hat / Virtualization