Re: [libvirt] PATCH: 6/12: Optional dlopen() support

On Thu, Nov 13, 2008 at 05:29:15PM +0000, Daniel P. Berrange wrote: > > This patch is a small incremental change to optionally allow us to build > every driver as a dlopen()able module. This is disabled by default for > now. I'm not sure whether this is hugely usefl or not, but it was easy > enough to do, so here's the patch. Good, I note there is also some renaming of entry points... I'm just a bit surprized it affects tests too ... > +++ b/tests/xmconfigtest.c Thu Nov 13 17:13:02 2008 +0000 [...] > virDomainDefFree(def); > - if (conn) { > - conn->privateData = old_priv; > - virConnectClose(conn); > - } > + VIR_FREE(conn); [...] > - if (conn) { > - conn->privateData = old_priv; > - virConnectClose(conn); > - } > + VIR_FREE(conn); hum, that's a bit surprizing, we are not closing the connection to free the data structure anymore ... I assume there is a good reason but that's obscure.