Re: [PATCH 7/7] qemu: Reserve bootIndexSpecified when update device

On Thu, Nov 17, 2022 at 10:05:33 +0800, Jiang Jiacheng wrote: > If the 'boot order' is not specified in the xml, we cancel its > bootindex setting and set it to '0'. However, the bootIndexSpecified > will be set to false because we cannot parse boot order from XML, > so copy bootIndexSpecified from origin device when updating it. > > Signed-off-by: Jiang Jiacheng <jiangjiacheng(a)huawei.com&gt; > --- > src/qemu/qemu_conf.c | 33 +++++++++++++++++++++++++++++++++ > src/qemu/qemu_conf.h | 4 ++++ > src/qemu/qemu_driver.c | 3 +++ > 3 files changed, 40 insertions(+) Rather than doing this qemuDomainUpdateDeviceFlags can parse the XML twice as it's acutally less work than invoking the copy function (Which re-formats the XML and parses it again). I'll post patches to adress that in qemuDomainUpdateDeviceFlags. You can drop this patch.