Re: [libvirt] [PATCH 3/8] Tweak daemon event debug to include errno
On Wed, Dec 01, 2010 at 12:22:53PM -0700, Eric Blake wrote:
On 12/01/2010 10:26 AM, Daniel P. Berrange wrote:
> * daemon/event.c: Include errno in debug info upon poll() failure
> ---
> daemon/event.c | 3 ++-
> 1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/daemon/event.c b/daemon/event.c
> index a983b35..0920748 100644
> --- a/daemon/event.c
> +++ b/daemon/event.c
> @@ -576,13 +576,14 @@ int virEventRunOnce(void) {
> retry:
> EVENT_DEBUG("Poll on %d handles %p timeout %d", nfds, fds, timeout);
> ret = poll(fds, nfds, timeout);
> - EVENT_DEBUG("Poll got %d event", ret);
> if (ret < 0) {
> + EVENT_DEBUG("Poll got error event %d", errno);
> if (errno == EINTR) {
> goto retry;
> }
> goto error_unlocked;
> }
> + EVENT_DEBUG("Poll got %d event(s)", ret);
ACK; independently useful, if you want to push now.
Pushed too
Daniel