On Tue, Jan 10, 2023 at 10:35:31AM -0500, Laine Stump wrote:
On 1/10/23 4:12 AM, Martin Kletzander wrote:
> On Tue, Jan 10, 2023 at 01:40:58AM -0500, Laine Stump wrote:
>> Signed-off-by: Laine Stump <laine(a)redhat.com>
>> ---
>> NEWS.rst | 10 ++++++++++
>> 1 file changed, 10 insertions(+)
>>
>> diff --git a/NEWS.rst b/NEWS.rst
>> index fecca64344..768208ed03 100644
>> --- a/NEWS.rst
>> +++ b/NEWS.rst
>> @@ -23,6 +23,16 @@ v9.0.0 (unreleased)
>> ``virDomainSnapshotDelete()``. Flags that allow deleting children
>> or children only are not supported.
>>
>> + * QEMU: support passt (
https://passt.top)
>> +
>> + passt can be used to connect an emulated network device to the
>> + host's network without requiring libvirt to have any sort of
>> + elevated privileges. This is configured with::
>
> s/::/:/
Actually that wasn't a typo - a double : causes the following lines to
be formatted as "code" (monospace font, no line filling), I think until
another blank line is encountered?
(The only reason I know this is from carg-culting the existing entries).
I looked at whether we are doing any special formatting for multiline
XMLs in the rest of the file especially for this purpose =) But totally
missed that there could be anything else than specific line dictating
the formatting.
Sorry for the suggested colonoscopy, keep it as is and my R-b still stands.
>
> Reviewed-by: Martin Kletzander <mkletzan(a)redhat.com>
>
>> +
>> + <interface type='user'>
>> + <backend type='passt'>
>> + ...
>> +
>> * **Improvements**
>>
>> * qemu: Prefer PNG for domain screenshots
>> --
>> 2.38.1
>>