Re: [PATCH v3 01/14] domain_conf: move boot timeouts check to domain_validate.c

On 12/8/20 11:20 PM, Daniel Henrique Barboza wrote: > This patch creates a new function, virDomainDefBootValidate(), to host > the validation of boot menu timeout and rebootTimeout outside of parse > time. The checks in virDomainDefParseBootXML() were changed to throw > VIR_ERR_XML_ERROR in case of parse error of those values. > > In an attempt to alleviate the amount of code being stacked inside > domain_conf.c, let's put this new function in a new domain_validate.c > file that will be used to place these validations. > > Suggested-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > Signed-off-by: Daniel Henrique Barboza <danielhb413(a)gmail.com&gt;

> diff --git a/src/conf/domain_validate.c b/src/conf/domain_validate.c > new file mode 100644 > index 0000000000..e4d947c553 > --- /dev/null > +++ b/src/conf/domain_validate.c > @@ -0,0 +1,51 @@ > +/* > + * domain_validate.c: domain general validation functions > + * > + * Copyright IBM Corp, 2020 Honestly, I have only vague idea how these Copyright lines work, but shouldn't they also include (at least subset) of the lines from the original file? I mean, my common sense tells me that if I have a file written by person X, and later the file is split into two the person X is still the original author. Extending that, if a company holds a copyright on a file then moving bits out to a different file should keep the copyright. But I admit that law has completely different model of "common sense". And also there is a disconnection between files and these Copyright lines. If a copyright holder Y changed a tiny bit that is not moved - should their Copyright line also appear in the new file?

Michal