Re: [libvirt] [Patch]: spice agent-mouse support
On Thu, Mar 1, 2012 at 5:32 PM, Daniel P. Berrange <berrange(a)redhat.com> wrote:
On Thu, Mar 01, 2012 at 11:54:30AM +0800, Zhou Peng wrote:
> Signed-off-by: Zhou Peng <zhoupeng(a)nfs.iscas.ac.cn>
>
> spice agent-mouse support
>
> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml
b/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml
> index 6505b55..266a4ed 100644
> --- a/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml
> +++ b/tests/qemuxml2argvdata/qemuxml2argv-channel-spicevmc.xml
> @@ -23,7 +23,7 @@
> <controller type='virtio-serial' index='1'>
> <address type='pci' domain='0x0000' bus='0x00'
slot='0x0a' function='0x0'/>
> </controller>
> - <graphics type='spice' port='5903' tlsPort='5904'
autoport='no' listen='127.0.0.1'>
> + <graphics type='spice' port='5903' tlsPort='5904'
autoport='no' listen='127.0.0.1' agentmouse='off'>
> <channel name='main' mode='secure'/>
> </graphics>
> <channel type='spicevmc'>
Rather than adding an attribute 'agentmouse' I think it'd be preferrable
to use a sub-element:
<agent mouse='on|off'/>
that way if we have more configuration related to the agent we have
a nice place to put it
Thanks for your review.
Based on qemu's argv, agent-mouse is used as one of -spice option's arg, which
specifys spice to use agent, but doesn't describe agent itself. It'
consistent with qemu's argv.
And there is no separated agent like option for qemu argv.
I think, If there is separated agent like option for qemu in the
future, we can add
agent sub-element directly to describe the agent itself, which does't conflict.
--
Zhou Peng