Re: [libvirt] [PATCH] virsh: Add missing "async" option in virsh-domain.c opts_block_commit.

On 09/19/2013 07:08 AM, Simone Gotti wrote: > After commit 8aecd351266a66efa59b7f7be77bf66693d99ce0 it'll detect Yay - my sanity checking found the first victim! Boohoo - that victim was me (the bug has been latent for 1 year now, introduced in ed23b1066). > that a required option is not defined and it will assert and exit with: > > virsh.c:1364: vshCommandOpt: Assertion `valid->name' failed. > --- > tools/virsh-domain.c | 4 ++++ > 1 file changed, 4 insertions(+) ACK. Needs an update to virsh.pod to match, so I squashed this in (borrowing from blockcopy) and pushed. Congratulations on your first libvirt patch.