Re: [libvirt PATCH] remote: fix driver name check for libxl driver
On Mon, 2020-05-04 at 12:10 -0600, Jim Fehlig wrote:
On 5/4/20 11:43 AM, Daniel P. Berrangé wrote:
> Can we changes the driver tables to use "Xen" too, now that we got
> rid of the old Xen driver. I can't remember if the driver tables
> names leak out anywhere important ?
It doesn't appear to be the case, but I only looked quickly and could have
missed something.
I'll send a patch to change 'name' in the driver tables. With the old Xen
driver
gone Andrea and I also discussed renaming the libxl driver to xen, but I'm not
sure it is worth the effort. It seems difficult to remove all references to
libxl. E.g. changing the '--with-libxl' configure option would break external
users/scripts.
I think it's fine to make changes to configure options, as long as
passing the old options results in a failure rather than silently
(not) enabling the driver. Our API stability guarantee thankfully
does *not* extend to configure :)
On the other hand, Any Minute Now™ we're going to switch to Meson,
at which point *all* of the existing options will break and all of
the scripts that exist will have to be updated. Maybe we can avoid
doing anything to autotools and just make sure the corresponding
Meson option is named correctly from day one?
Adding Pavel to the conversation.
--
Andrea Bolognani / Red Hat / Virtualization