Re: [libvirt PATCH 1/4] docs: Use consistent style in pci-addresses.rst

On Thu, Apr 16, 2020 at 01:35:57PM +0200, Andrea Bolognani wrote: > On Thu, 2020-04-16 at 12:58 +0200, Ján Tomko wrote: > > On a Wednesday in 2020, Andrea Bolognani wrote: > > > Indent all code snippets by the same number of spaces, and don't > > > embed the :: marker in the line preceding a code block. > > > > But why? It's so ugly. > > I disagree, and find it much easier on the eye than the alternative. > > That's a matter of personal preference, of course, but the fact that > all existing reStructuredText files in the repository follow this > convention could indicate that I'm not the only one holding this > opinion. This change was made for consistency's sake, not to appease > my sense of aestethic - althought in this case the two overlap :) BTW, we could update styleguide.rst to mention this preference.