Re: [libvirt] [PATCH libvirt-glib 02/15] Add objects for dealing with <console> devices

The code by itself is fine, but I'm not sure about the design If we go this way, we'll have GVirConfigDomainConsolePty, GVirConfigDomainConsoleStdio, GVirConfigDomainConsoleFile, and then GVirConfigDomainSerialPty, GVirConfigDomainSerialStdio, GVirConfigDomainSerialFile, and the same for channels and parallel ports. Something that might work is having GVirConfigDomainChardev as a base class for GVirConfigDomainConsole, GVirConfigDomainSerial, ... Then we'd also have a GVirConfigDomainChardevSource from which GVirConfigDomainChardevSourcePty, GVirConfigDomainChardevSourceStdio, GVirConfigDomainChardevSourceFile, ... would derive. And finally we'd have some kind of gvir_config_domain_chardev_add_source API to combine the 2 (GVirConfigDomainConsole + GVirConfigDomainChardevSourcePty). There's the added complication that sometimes you have multiple source XML nodes, sometimes you have a protocol node, so maybe GVirConfigDomainChardevSourcePty would not even derive from GVirConfigObject to allow handling that, or it would have a fake <chardev> toplevel node.