Re: [libvirt PATCH 114/351] meson: add default_editor build option
On Wed, Jul 22, 2020 at 04:44:32PM +0200, Peter Krempa wrote:
On Thu, Jul 16, 2020 at 11:55:50 +0200, Pavel Hrdina wrote:
> Signed-off-by: Pavel Hrdina <phrdina(a)redhat.com>
> ---
> configure.ac | 3 ---
> m4/virt-default-editor.m4 | 32 --------------------------------
> meson.build | 3 +++
> meson_options.txt | 1 +
> 4 files changed, 4 insertions(+), 35 deletions(-)
> delete mode 100644 m4/virt-default-editor.m4
I'd also argue for removing all of this and plainly erroring out in
virsh if 'EDITOR' env variable is not set.
That's a bit unkind - normal practice is to have a fallback if EDITOR
or VISUAL aren't set. IIUC, POSIX suggests "vi" as the default, but
we could do better and default to libreoffice writer ;-P
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|