Re: [libvirt] [PATCH] qemu: Make domain renaming work during migration

On 09/03/2013 07:46 AM, Jiri Denemark wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=999352 > > Since commit v1.0.5-56-g449e6b1 (Pull parsing of migration xml up into > QEMU driver APIs) any attempt to rename a domain during migration fails > with the following error message: > > internal error Incoming cookie data had unexpected name DOM vs DOM2 > > This is because migration cookies always use the original domain name > and the mentioned commit failed to propagate the name back to > qemuMigrationPrepareAny. > --- > src/qemu/qemu_driver.c | 36 ++++++++++++++++++++++++------------ > src/qemu/qemu_migration.c | 31 +++++++++++++++++++------------ > src/qemu/qemu_migration.h | 5 ++++- > 3 files changed, 47 insertions(+), 25 deletions(-) Bummer of a regression; and it takes quite a bit of code to restore documented functionality. ACK.