Re: [libvirt] [PATCH 1/3] bhyve: implement support for commandline args
John Ferlan wrote:
> diff --git
a/tests/bhyvexml2argvdata/bhyvexml2argv-commandline.args
b/tests/bhyvexml2argvdata/bhyvexml2argv-commandline.args
> new file mode 100644
> index 0000000000..cb21b99cd6
> --- /dev/null
> +++ b/tests/bhyvexml2argvdata/bhyvexml2argv-commandline.args
> @@ -0,0 +1,9 @@
> +/usr/sbin/bhyve \
> +-c 1 \
> +-m 214 \
> +-u \
> +-H \
> +-P \
> +-s 0:0,hostbridge \
> +-s 2:0,ahci,hd:/tmp/freebsd.img \
> +-s 3:0,virtio-net,faketapdev,mac=52:54:00:b9:94:02 ARGUMENT1 ARGUMENT2 bhyve
From the not that matters but viewpoint:
-s 3:0,virtio-net,faketapdev,mac=52:54:00:b9:94:02 \
ARGUMENT1 ARGUMENT2 bhyve
It fails test-wrap-argv this way:
GEN test-wrap-argv
--- tests/bhyvexml2argvdata/bhyvexml2argv-commandline.args 2019-01-27
11:36:11.493854000 +0400
+++ - 2019-01-27 11:36:20.275734000 +0400
@@ -6,5 +6,4 @@
-P \
-s 0:0,hostbridge \
-s 2:0,ahci,hd:/tmp/freebsd.img \
--s 3:0,virtio-net,faketapdev,mac=52:54:00:b9:94:02 \
-ARGUMENT1 ARGUMENT2 bhyve
+-s 3:0,virtio-net,faketapdev,mac=52:54:00:b9:94:02 ARGUMENT1 ARGUMENT2 bhyve
Incorrect line wrapping in tests/bhyvexml2argvdata/bhyvexml2argv-commandline.args
Use test-wrap-argv.pl to wrap test data files
gmake: *** [cfg.mk:1149: test-wrap-argv] Error 1
Roman Bogorodskiy
Attachments:
- signature.asc (application/pgp-signature — 455 bytes)