Re: [libvirt PATCH] spec: Explain the BuildRequires on firewalld-filesystem

On Thu, Oct 8, 2020 at 7:06 AM Andrea Bolognani <abologna(a)redhat.com&gt; wrote: > > It's not immediately obvious why it is needed. > > Suggested-by: Pavel Hrdina <phrdina(a)redhat.com&gt; > Signed-off-by: Andrea Bolognani <abologna(a)redhat.com&gt; > --- > libvirt.spec.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libvirt.spec.in b/libvirt.spec.in > index 6d4eef86ad..c0d84c0e75 100644 > --- a/libvirt.spec.in > +++ b/libvirt.spec.in > @@ -399,6 +399,7 @@ BuildRequires: rpcgen > > BuildRequires: libtirpc-devel > > +# Needed for the %firewalld_reload macro > %if %{with_firewalld_zone} > BuildRequires: firewalld-filesystem > %endif > -- > 2.26.2 > I'd suggest putting the comment inside the conditional, but otherwise it's fine.

Reviewed-by: Neal Gompa <ngompa13(a)gmail.com&gt;