Re: [libvirt] [PATCH] New features implemented in hyperv libvirt driver
Do I need credentials and/or specific rights on the libvirt git to do that?
-----Message d'origine-----
De : Daniel P. Berrange [mailto:berrange@redhat.com]
Envoyé : mercredi 1 octobre 2014 10:58
À : Yves Vinter
Cc : Christophe Fergeau; libvir-list(a)redhat.com
Objet : Re: [libvirt] [PATCH] New features implemented in hyperv libvirt driver
On Wed, Oct 01, 2014 at 08:37:43AM +0000, Yves Vinter wrote:
Hi Christophe,
I understand clearly the process.
I was just asking if there are some other requirements I should be
aware of juts to save time.
BTW.
Splitting the developments into several patchs (by features) will
introduce a dependency between them; they will have to be reviewed and
applied in a specific order.
Does it mean that the new set of patch must be submitted one after one
? In case a patch needs to be revised, all other patchs (on the same
source code) may need to be regenerated, right ?
Yes, that's correct. When working on a large feature like this our general
recommendation is to create a branch for the new work. Then on that branch you'll end
up with a sequence of patches committed. You can use 'git rebase -i master' to
edit that series of patches to prepare it. Once you're happy with the branch then if
you use 'git send-email master..' it will automatically turn the contents of your
current branch into a series of linked emails and send them to the list in the right
order.
If you've not used git send-email before, it is wise to test it first by sending the
patches to your own email address. That lets you see that they are formatted how you
expect, before sending them to this mailing list.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|