Re: [libvirt] [PATCH v3 01/11] libvirt: Export libvirt config getters by moving them to util
On Fri, Nov 06, 2015 at 12:46:16PM +0100, Erik Skultety wrote:
virConnectGetConfig and virConnectGetConfigPath were static libvirt
methods, merely because there hasn't been any need for having them
internally exported yet. Since libvirt-admin also needs to reference
libvirt config file, 'xGetConfig' should be exported.
Besides moving, this patch also renames the methods accordingly,
as they are libvirt config specific.
The libvirt.conf file is providing configuration for the
libvirt.so client library. I'm not convinced we should
use that same configuration file for the libvirt-admin.so
library. Although it is also a client, it is essentially
a completely separate library since it is speaking a
different protocol and is targetted at different users.
So I think we should have a libvirt-admin.conf file for
the libvirt-admin.so client library.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|