Re: [libvirt] [PATCH 09/19] virdomainobjlist: Add vnc into filter group to check the vnc existence of guest
On Mon, Nov 02, 2020 at 16:26:11 +0800, Lin Ma wrote:
Signed-off-by: Lin Ma <lma(a)suse.com>
---
include/libvirt/libvirt-domain.h | 3 +++
src/conf/virdomainobjlist.c | 15 +++++++++++++++
src/conf/virdomainobjlist.h | 7 ++++++-
3 files changed, 24 insertions(+), 1 deletion(-)
I'm not persuaded (and the non-existing commit message doesn't help)
that we should add arbitrary filters here. Specifically there's a rather
limited amount of flags we can use for filtering and thus we should not
add them without proper consideration.
Specifically anything that is related to VM config is for me off limits
to be used as filtering as there are many options and they may change
over time.
This filtering can be done client side. It will be expensive, but
command line completers are not really intensively used code paths.
NACK