Re: [libvirt] [PATCH 2/2] qemu: attach: Close monitor socket on connection failure

On Mon, Oct 03, 2016 at 01:32:47PM +0200, Peter Krempa wrote:

If attaching to a qemu process fails after opening the monitor socket libvirt does not clean up the monitor. As the monitor also holds a reference to the domain object the qemu attach API basically leaks it.

QEMU also does not interact on a second monitor connection and thus a further attempt to attach to it would lock up.

Prevent libvirt from leaking the monitor by explicitly closing it.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1378401 --- src/qemu/qemu_process.c | 3 +++ 1 file changed, 3 insertions(+)

ACK Jan