Re: [libvirt] [Qemu-devel] [PATCH v3 00/10] dirty-bitmaps: deprecate @status field

Patchew URL: https://patchew.org/QEMU/20190223000614.13894-1-jsnow@redhat.com/ Hi, This series seems to have some coding style problems. See output below for more information: Message-id: 20190223000614.13894-1-jsnow(a)redhat.com Subject: [Qemu-devel] [PATCH v3 00/10] dirty-bitmaps: deprecate @status field Type: series === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 * [new tag] patchew/20190220160628.6555-1-marcandre.lureau(a)redhat.com -> patchew/20190220160628.6555-1-marcandre.lureau(a)redhat.com Switched to a new branch 'test' 5615f81566 iotests: add busy/recording bit test to 124 7c4f722b89 blockdev: remove unused paio parameter documentation 30e0427368 block/dirty-bitmaps: move comment block a29ece1728 block/dirty-bitmaps: unify qmp_locked and user_locked calls 3d0665404c block/dirty-bitmap: explicitly lock bitmaps with successors d932d4e9c4 nbd: change error checking order for bitmaps 2ee1f03bae block/dirty-bitmap: change semantics of enabled predicate 4fca6cb44e block/dirty-bitmap: remove set/reset assertions against enabled bit 7d032c41b8 block/dirty-bitmaps: rename frozen predicate helper 9d17322444 block/dirty-bitmap: add recording and busy properties === OUTPUT BEGIN === 1/10 Checking commit 9d1732244435 (block/dirty-bitmap: add recording and busy properties) 2/10 Checking commit 7d032c41b8ab (block/dirty-bitmaps: rename frozen predicate helper) WARNING: line over 80 characters #85: FILE: block/dirty-bitmap.c:248: + error_setg(errp, "Cannot create a successor for a bitmap that is in-use " total: 0 errors, 1 warnings, 122 lines checked Patch 2/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/10 Checking commit 4fca6cb44e9b (block/dirty-bitmap: remove set/reset assertions against enabled bit) 4/10 Checking commit 2ee1f03baedb (block/dirty-bitmap: change semantics of enabled predicate) 5/10 Checking commit d932d4e9c476 (nbd: change error checking order for bitmaps) 6/10 Checking commit 3d0665404c60 (block/dirty-bitmap: explicitly lock bitmaps with successors) 7/10 Checking commit a29ece1728f0 (block/dirty-bitmaps: unify qmp_locked and user_locked calls) ERROR: open brace '{' following function declarations go on the next line #37: FILE: block/dirty-bitmap.c:190: +bool bdrv_dirty_bitmap_busy(BdrvDirtyBitmap *bitmap) { total: 1 errors, 0 warnings, 263 lines checked Patch 7/10 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 8/10 Checking commit 30e042736827 (block/dirty-bitmaps: move comment block) 9/10 Checking commit 7c4f722b8967 (blockdev: remove unused paio parameter documentation) 10/10 Checking commit 5615f815663d (iotests: add busy/recording bit test to 124) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190223000614.13894-1-jsnow@redhat.com/testing.c.... --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel(a)redhat.com