Re: [libvirt] [PATCH v2] virsh: Allow other escape characters for console

On 11/24/2011 04:03 AM, Michal Privoznik wrote: > Currently virsh supports only ^] as escape character for console. > However, some users might want to use something else. This patch > creates such ability by specifying '-e' switch on virsh command > line. > --- > diff to v1: > -Eric's review included > > tools/console.c | 26 +++++++++++++++++++++----- > tools/console.h | 4 +++- > tools/virsh.c | 40 +++++++++++++++++++++++++++++++--------- > tools/virsh.pod | 5 +++++ > 4 files changed, 60 insertions(+), 15 deletions(-)

ACK with nits fixed, and apologies for the slow review.