Re: [PATCH v7 1/4] qemu: capablities: detect presence of acpi-root-pci-hotplug for i440fx machines
On Mon, Oct 04, 2021 at 10:19:17PM +0530, Ani Sinha wrote:
On Mon, 4 Oct 2021, Andrea Bolognani wrote:
> On Fri, Oct 01, 2021 at 02:59:45PM +0530, Ani Sinha wrote:
> > +++ b/src/qemu/qemu_capabilities.c
> > + /* 410 */
> > + "piix4-acpi-root-hotplug-en", /*
QEMU_CAPS_PIIX_ACPI_ROOT_PCI_HOTPLUG */
>
> Sorry if this is a silly question, but can you please explain where
> the "-en" suffix comes from?
"en" stands for enable.
AFAICT there are no other capabilities that use this convention.
Moreover, the option can be used both to enable *and* disable
hotplug, so the name doesn't seem accurate either...
The string is not exposed to users, so ultimately none of this really
matters, but I would still suggest changing it to
piix4.acpi-root-pci-hotplug
I'd be happy to either review a patch of yours that does that, or
preparing such a patch myself.
--
Andrea Bolognani / Red Hat / Virtualization