Re: [libvirt] [PATCH 00/12] Various libxl driver improvements
Eric Blake wrote:
On 09/04/2013 03:09 PM, Jim Fehlig wrote:
>>>
>>>
> Thanks for pointing that out. What do you think of the attached patch?
>
> Regards,
> Jim
>
>
> libxl-coverity-fix.patch
>
>
> >From fe87e804478689b7cdf0ab417b459cb0d2f6118e Mon Sep 17 00:00:00 2001
> From: Jim Fehlig <jfehlig(a)suse.com>
> Date: Wed, 4 Sep 2013 14:27:20 -0600
> Subject: [PATCH] libxl: Fix Coverity warning
>
> John Ferlan reported the following Coverity warning:
>
> In libxlDomainCoreDump() Coverity has noted a FORWARD_NULL reference:
>
>
> Removing the vm from domain obj list and setting it to NULL can be
> done in the previous 'if (flags & VIR_DUMP_CRASH)' conditional. Fix
> the Coverity warning by ensuring vm is not NULL before testing if it
> is still active.
>
> Signed-off-by: Jim Fehlig <jfehlig(a)suse.com>
> ---
> src/libxl/libxl_driver.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)
>
ACK.
Thanks, pushed.
Regards,
Jim