Re: [libvirt] [PATCH] time_t is not a long on FreeBSD, need to add casts

On 05/12/2011 11:53 PM, Matthias Bolte wrote: > --- >  src/conf/domain_conf.c |    6 +++--- >  1 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index d3efec6..875f90e 100644 > --- a/src/conf/domain_conf.c > +++ b/src/conf/domain_conf.c > @@ -9115,7 +9115,7 @@ virDomainSnapshotDefPtr virDomainSnapshotDefParseString(const char *xmlStr, > >      def->name = virXPathString("string(./name)", ctxt); >      if (def->name == NULL) > -        ignore_value(virAsprintf(&def->name, "%ld", tv.tv_sec)); > +        ignore_value(virAsprintf(&def->name, "%ld", (long)tv.tv_sec)); Ouch.  Cygwin is thinking of making time_t a 64-bit entity, but since cygwin is 32-bit, that's larger than long. We need to use %lld and (long long) instead (or %jd and intmax_t).